Remove unneeded reserve() calls #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure. Do you know what size the coeff and var vectors typically are? The normal automatic vector reserve growing behavior is by a fixed factor of 1.5, so in the worst case we only use 1.5 times the amount of memory compared to the current situation. |
|
I will run heaptrack in the near future. |
Levi-Armstrong
approved these changes
Mar 5, 2024
Levi-Armstrong
merged commit 47d8bf5
into
tesseract-robotics:master
8 of 10 checks passed
|
I just read that a shrink_to_fit can also cause a reallocation. So unless we really need the memory it's not advisable to use it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In expr_ops.hpp reserve() was called at every variable update. This causes the variable and coefficient vectors to be relocated very often, as their size is updated by a minimal amount every time . Removing the reserve() calls allows the vectors to use their normal growing behavior, improving performance.
Before:
After:
